-
-
Notifications
You must be signed in to change notification settings - Fork 829
Fix VoIP event tile issues #6471
Fix VoIP event tile issues #6471
Conversation
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
be28f4e
to
8c63588
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me code wise!
When message bubbles are enabled the tiles are collapsed, but that will be fixed by #6465
Will make sure that a design review is fast tracked for this PR to unblock RC tomorrow
Thank you for your continuous contributions 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Šimon!
Just a couple details we'd need to update to get this PR ready for the next RC.
- Iconography: Update the missed-voice.svg icon to the one I'm attaching (it follows the latest Design System specs)
- Copy: Update the i18n strings "The remote side declined this call" and "The remote side didn't pick up", by replacing "The remote side" part with just "They".
Thanks for the review!
I am a little confused, sorry - should I use the missed voice call icon even for missed video calls? (the current icon should be from https://www.figma.com/file/V6m2z0oAtUV1l8MdyIrAep/VoIP?node-id=2863%3A45199)
Yeah, sounds much better |
Signed-off-by: Šimon Brandner <[email protected]>
Sorry for the confusion, Šimon! It actually was |
Ah, no worries 😄 I'll revert the change |
c9dfe74
to
29b0d03
Compare
Do you need me to retake the screenshots? (everything should be updated now) |
Don't bother taking new screenshots. Thanks anyway! |
Fixes element-hq/element-web#18216
element-web notes: none